D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 15838 - Many Win32 API callback functions miss extern(Windows)
Summary: Many Win32 API callback functions miss extern(Windows)
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: druntime (show other issues)
Version: D2
Hardware: All Windows
: P1 major
Assignee: No Owner
URL:
Keywords: pull
: 16032 (view as issue list)
Depends on:
Blocks:
 
Reported: 2016-03-27 07:14 UTC by jiki
Modified: 2018-01-05 13:27 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description jiki 2016-03-27 07:14:59 UTC
2.070 druntime comes with rich core.sys.windows.* headers for Windows.

So, each of their functions should have an exact linkage type.
Otherwise the calls to them will cause runtime errors.

I found a number of the mismatch for (only) the callback functions,
and will send a PR for it.
Comment 2 github-bugzilla 2016-04-10 15:07:09 UTC
Commits pushed to master at https://github.com/D-Programming-Language/druntime

https://github.com/D-Programming-Language/druntime/commit/699dab51b73c37ccf3e397cffb34c2c49198f7e6
Fix issue 15838 	Many Win32 API callback functions miss extern(Windows)

Add extern (Windows) to aliases and struct fields.

https://github.com/D-Programming-Language/druntime/commit/ce29bfc31385a988555a0ba1ab335c81c5173b03
Merge pull request #1525 from qchikara/pr_win32_callbacks_linkeage

Fix issue 15838 	Many Win32 API callback functions miss extern(Windows)
Comment 3 jiki 2016-05-18 03:55:52 UTC
*** Issue 16032 has been marked as a duplicate of this issue. ***
Comment 4 github-bugzilla 2016-10-01 11:44:37 UTC
Commits pushed to stable at https://github.com/dlang/druntime

https://github.com/dlang/druntime/commit/699dab51b73c37ccf3e397cffb34c2c49198f7e6
Fix issue 15838 	Many Win32 API callback functions miss extern(Windows)

https://github.com/dlang/druntime/commit/ce29bfc31385a988555a0ba1ab335c81c5173b03
Merge pull request #1525 from qchikara/pr_win32_callbacks_linkeage
Comment 5 github-bugzilla 2018-01-05 13:27:27 UTC
Commits pushed to dmd-cxx at https://github.com/dlang/druntime

https://github.com/dlang/druntime/commit/699dab51b73c37ccf3e397cffb34c2c49198f7e6
Fix issue 15838 	Many Win32 API callback functions miss extern(Windows)

https://github.com/dlang/druntime/commit/ce29bfc31385a988555a0ba1ab335c81c5173b03
Merge pull request #1525 from qchikara/pr_win32_callbacks_linkeage