D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 17340 - [REG 2.074.0] isNumeric!bool should not be true
Summary: [REG 2.074.0] isNumeric!bool should not be true
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: phobos (show other issues)
Version: D2
Hardware: All All
: P1 regression
Assignee: No Owner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-22 01:02 UTC by thomas.bockman
Modified: 2018-01-05 13:28 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description thomas.bockman 2017-04-22 01:02:33 UTC
A regression was introduced in this commit:
https://github.com/dlang/phobos/commit/a07517abae8dce9e0687913b1a03c942aed60dce

std.traits.isNumeric!bool should be false.
Comment 1 thomas.bockman 2017-04-22 01:07:42 UTC
The new (wrong) behaviour was also retroactively added to the documentation in a later commit:
https://github.com/dlang/phobos/commit/118f2d773317d0da76c0d9054e7bcddd2e83f887

However, prior to DMD 2.074 isNumeric did not work this way. It's a (presumably accidental) breaking change.
Comment 2 thomas.bockman 2017-04-22 01:12:28 UTC
I submitted a fix: https://github.com/dlang/phobos/pull/5343
Comment 3 github-bugzilla 2017-04-27 19:17:11 UTC
Commits pushed to stable at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/83f757c17737cca5faeecdc77cae350f0bad9a4e
Fix issue 17340 - isNumeric!bool should not be true

https://github.com/dlang/phobos/commit/ef025a64ab1115281a033f6e8ad56421a23bd12b
Merge pull request #5343 from tsbockman/is_bool_numeric

Fix issue 17340 - isNumeric!bool should not be true
Comment 4 github-bugzilla 2017-05-29 23:02:14 UTC
Commits pushed to master at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/83f757c17737cca5faeecdc77cae350f0bad9a4e
Fix issue 17340 - isNumeric!bool should not be true

https://github.com/dlang/phobos/commit/ef025a64ab1115281a033f6e8ad56421a23bd12b
Merge pull request #5343 from tsbockman/is_bool_numeric
Comment 5 github-bugzilla 2018-01-05 13:28:28 UTC
Commits pushed to dmd-cxx at https://github.com/dlang/phobos

https://github.com/dlang/phobos/commit/83f757c17737cca5faeecdc77cae350f0bad9a4e
Fix issue 17340 - isNumeric!bool should not be true

https://github.com/dlang/phobos/commit/ef025a64ab1115281a033f6e8ad56421a23bd12b
Merge pull request #5343 from tsbockman/is_bool_numeric