D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 17805 - -dirty flag on dmd's version
Summary: -dirty flag on dmd's version
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: dmd (show other issues)
Version: D2
Hardware: All Linux
: P1 major
Assignee: No Owner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-04 18:18 UTC by Martin Nowak
Modified: 2017-10-02 20:54 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Martin Nowak 2017-09-04 18:18:17 UTC
Since 2.076.0 dmd's version has the -dirty flag set. We've changed the version determinatio https://github.com/dlang/dmd/commit/09cc628724be87a6e317223059202ea652630ef5 and now the release build script seems to pick up the -dirty from it's git repo.
There shouldn't be any difference though, the only thing the build script changes is to overwrite the VERSION file.
Comment 1 github-bugzilla 2017-09-04 21:07:24 UTC
Commits pushed to stable at https://github.com/dlang/installer

https://github.com/dlang/installer/commit/8715780b3085d4427ec14960ca5b1afe9820ed45
fix Issue 17805 - -dirty flag on dmd's version

- stop overwriting dmd's VERSION file for release building
  and instead verify that it matches the gitTag
- -dirty flag of git describe was caused by
  newline mismatch in VERSION file

https://github.com/dlang/installer/commit/f1443c04d1066b33823e79e6447902de9cda0836
Merge pull request #250 from MartinNowak/fix17805

fix Issue 17805 - -dirty flag on dmd's version
Comment 2 github-bugzilla 2017-10-02 20:54:46 UTC
Commits pushed to master at https://github.com/dlang/installer

https://github.com/dlang/installer/commit/8715780b3085d4427ec14960ca5b1afe9820ed45
fix Issue 17805 - -dirty flag on dmd's version

https://github.com/dlang/installer/commit/f1443c04d1066b33823e79e6447902de9cda0836
Merge pull request #250 from MartinNowak/fix17805