Issue 1890 - DDOC removes leading space in D_CODE macro
Summary: DDOC removes leading space in D_CODE macro
Status: ASSIGNED
Alias: None
Product: D
Classification: Unclassified
Component: dmd (show other issues)
Version: D2
Hardware: All All
: P3 normal
Assignee: No Owner
URL:
Keywords: bootcamp, ddoc, patch, pull
Depends on:
Blocks:
 
Reported: 2008-03-03 11:37 UTC by Derek Parnell
Modified: 2022-12-17 10:45 UTC (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Derek Parnell 2008-03-03 11:37:33 UTC
The following text ...
$(D_CODE
  aaa
  bbb
  ccc
)

generates ...

<pre> aaa
  bbb
  ccc
 </pre>

Notice:
(A) That the two spaces before "aaa" have been rendered with only one space.
(B) One space preceeds the </pre>. 

Because the definition of D_CODE is <pre>$0</pre> I expected this instead to be generated ...

<pre>
  aaa
  bbb
  ccc
</pre>
Comment 1 Max Samukha 2008-03-03 12:42:39 UTC
From the Ddoc spec: "Macros can have arguments. Any text from the end of the identifier to the closing ')' is the $0 argument".

The spec does not elaborate on where is the end of the identifier and the start of the text. According to the spec, an undefined number of whitespace characters may be skipped to get to the start of the argument, the rest of whitespace may be arbitrarily replaced with <br><br>. :)

The start of the argument might have been defined as the first non-whitespace character or the first vertical space character, whichever comes first.
Comment 2 Derek Parnell 2008-03-03 15:05:34 UTC
I wish it was using the rule "The start of the argument might have been defined as the first non-whitespace character or the first vertical space character, whichever comes first." because then it would come out as I had expected. But it is definitely just eating the first space character and leaving the rest. Also, in my original post, point (B) is not true. I messed up the test file. Only point (A) is still at fault, IMHO.
Comment 3 Denis Shelomovskii 2011-11-02 06:06:28 UTC
Ping. Isn't this bug trivial to fix? And it is an error-prone one, because us usually expects that the start of the argument is "the first non-whitespace character", but it isn't now. Worst of all it is undocumented now. `WEB` macros suffers from this bug, look at broken links to STL at
http://d-programming-language.org/phobos/std_range.html#lowerBound
Comment 5 Dlang Bot 2019-09-27 12:06:27 UTC
@RazvanN7 created dlang/dmd pull request #10444 "Fix Issue 1890 - DDOC removes leading space in D_CODE macro" fixing this issue:

- Fix Issue 1890 - DDOC removes leading space in D_CODE macro

https://github.com/dlang/dmd/pull/10444