D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 19623 - HERE string identifier cannot start with Unicode letter
Summary: HERE string identifier cannot start with Unicode letter
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: dmd (show other issues)
Version: D2
Hardware: All All
: P1 trivial
Assignee: No Owner
URL:
Keywords: pull, rejects-valid, trivial
Depends on:
Blocks:
 
Reported: 2019-01-27 04:40 UTC by Marco Leise
Modified: 2022-11-07 22:57 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Marco Leise 2019-01-27 04:40:43 UTC 
The character c is actually not a decoded dchar, but the first byte from the sequence. Subsequently the test for Unicode letters fails here:

https://github.com/dlang/dmd/blob/77260f78e45675bb1418feb9836ed0c6252fd1b9/src/dmd/lexer.d#L1504

So this would fail:

q"übel
übel"
Comment 1 Dlang Bot 2022-11-06 16:30:20 UTC 
@dkorpel created dlang/dmd pull request #14625 "Fix 19623 - HERE string identifier cannot start with Unicode letter" fixing this issue:

- Fix 19623 - HERE string identifier cannot start with Unicode letter

https://github.com/dlang/dmd/pull/14625
Comment 2 Dlang Bot 2022-11-07 22:57:32 UTC 
dlang/dmd pull request #14625 "Fix 19623 - HERE string identifier cannot start with Unicode letter" was merged into master:

- c0403e605bee1cfcba4ba31c2f06f2b77fc769d9 by Dennis Korpel:
  Fix 19623 - HERE string identifier cannot start with Unicode letter

https://github.com/dlang/dmd/pull/14625