D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work
Summary: std.zip: zip64 with 0xff bytes in end of central dir record do not work
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: phobos (show other issues)
Version: D2
Hardware: All All
: P1 regression
Assignee: No Owner
URL:
Keywords: pull
Depends on:
Blocks:
 
Reported: 2019-10-10 19:19 UTC by berni44
Modified: 2019-10-18 00:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description berni44 2019-10-10 19:19:58 UTC
In zip64 files, some values in the end of central dir record can be replaced by 0xff bytes. The correct values can be found elsewhere. When looking for the end of central dir record, this has to be taken into account.

This problem has probably been introduced by PR #7198.

I've got allready a fix for this, but want to add a unittest which is more difficult to create...
Comment 1 Dlang Bot 2019-10-10 19:52:10 UTC
@berni44 created dlang/phobos pull request #7224 "Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work" fixing this issue:

- Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work

https://github.com/dlang/phobos/pull/7224
Comment 2 Dlang Bot 2019-10-16 08:42:12 UTC
@berni44 created dlang/phobos pull request #7229 "Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work" fixing this issue:

- Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work

https://github.com/dlang/phobos/pull/7229
Comment 3 Dlang Bot 2019-10-18 00:00:53 UTC
dlang/phobos pull request #7229 "Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work" was merged into stable:

- 531951d8563460cd856d3047489f5a51ad31932f by Bernhard Seckinger:
  Fix issue #20295 - std.zip: zip64 with 0xff bytes in end of central dir record do not work

https://github.com/dlang/phobos/pull/7229