D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 21555 - std.container.array: insertBack is wrong and should be tested for Array!bool
Summary: std.container.array: insertBack is wrong and should be tested for Array!bool
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: phobos (show other issues)
Version: D2
Hardware: All All
: P1 normal
Assignee: No Owner
URL:
Keywords: pull
Depends on:
Blocks: 21556
  Show dependency tree / graph
 
Reported: 2021-01-18 01:29 UTC by Luís Ferreira
Modified: 2021-01-19 01:20 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Luís Ferreira 2021-01-18 01:29:23 UTC 
The given code reports 0 inserted elements and the final array is [false], so this is clearly wrong and should be covered.
---

import std;

void main()
{
    Array!bool atum;
    writeln(atum.insertBack([false]));
    writeln(atum[]);
}
Comment 1 Luís Ferreira 2021-01-18 01:29:28 UTC 
I'm already working on a fix.
Comment 2 Dlang Bot 2021-01-18 20:55:37 UTC 
@ljmf00 updated dlang/phobos pull request #7750 "Fix issue 21555, 21556 - container: array: insertAfter and insertBack are wrong" fixing this issue:

- Fix issue 21555: std.container.array: insertBack is wrong and should be tested for Array!bool
  
  insertBack() returns 0 inserted elements everytime due to a preformed
  .popFront() on the range.
  
  Signed-off-by: Luís Ferreira <contact@lsferreira.net>

- Fix issues 21555, 21556: container: array: add missing tests for Array!T .insertBack and .insertAfter
  
  Signed-off-by: Luís Ferreira <contact@lsferreira.net>

https://github.com/dlang/phobos/pull/7750
Comment 3 Dlang Bot 2021-01-19 01:20:16 UTC 
dlang/phobos pull request #7750 "Fix issue 21555, 21556 - container: array: insertAfter and insertBack are wrong" was merged into master:

- 93ebaa729116a813ebb2a8d175abe4400ec00ecf by Luís Ferreira:
  Fix issue 21555: std.container.array: insertBack is wrong and should be tested for Array!bool
  
  insertBack() returns 0 inserted elements everytime due to a preformed
  .popFront() on the range.
  
  Signed-off-by: Luís Ferreira <contact@lsferreira.net>

- 30f71fd5705beaa3dc9c5131b081c60ccaa0974c by Luís Ferreira:
  Fix issues 21555, 21556: container: array: add missing tests for Array!T .insertBack and .insertAfter
  
  Signed-off-by: Luís Ferreira <contact@lsferreira.net>

https://github.com/dlang/phobos/pull/7750