D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 22998 - Update to zlib 1.2.12
Summary: Update to zlib 1.2.12
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: phobos (show other issues)
Version: D2
Hardware: x86 Windows
: P1 normal
Assignee: No Owner
URL:
Keywords: pull
Depends on:
Blocks:
 
Reported: 2022-04-09 16:19 UTC by Brian Callahan
Modified: 2022-04-10 15:45 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Brian Callahan 2022-04-09 16:19:14 UTC 
Hello --

I've updated the copy of zlib in Phobos.

Here's a reprinting of the big-ticket items from the zlib.net homepage:
Version 1.2.12 has these key improvements over 1.2.11:

* Fix a deflate bug when using the Z_FIXED strategy that can result in out-of-bound accesses.
* Fix a deflate bug when the window is full in deflate_stored().
* Speed up CRC-32 computations by a factor of 1.5 to 3.
* Use the hardware CRC-32 instruction on ARMv8 processors.
* Speed up crc32_combine() with powers of x tables.
* Add crc32_combine_gen() and crc32_combine_op() for fast combines.
Due to the bug fixes, any installations of 1.2.11 should be replaced with 1.2.12.

Also maintains the fix from here:
https://github.com/ibara/phobos/commit/1b6cf80232f19e581f72869a4b339580416dd72d

Everything appears OK on my OpenBSD/amd64 machine. But perhaps more testing from others is in order.
Comment 1 Dlang Bot 2022-04-09 19:49:02 UTC 
@ibara updated dlang/phobos pull request #8428 "Fix Issue 22998 - Update to zlib 1.2.12" fixing this issue:

- Fix Issue 22998 - Update to zlib 1.2.12
  Update zlib to the 1.2.12 release
  Version 1.2.12 has these key improvements over 1.2.11:
  * Fix a deflate bug when using the Z_FIXED strategy that can result in out-of-bound accesses.
  * Fix a deflate bug when the window is full in deflate_stored().
  * Speed up CRC-32 computations by a factor of 1.5 to 3.
  * Use the hardware CRC-32 instruction on ARMv8 processors.
  * Speed up crc32_combine() with powers of x tables.
  * Add crc32_combine_gen() and crc32_combine_op() for fast combines.
  Due to the bug fixes, any installations of 1.2.11 should be replaced with 1.2.12.

https://github.com/dlang/phobos/pull/8428
Comment 2 Dlang Bot 2022-04-10 15:45:09 UTC 
dlang/phobos pull request #8428 "Fix Issue 22998 - Update to zlib 1.2.12" was merged into master:

- 3b16b03f6d1ab1dfb823510400987679d94bb4d4 by Brian Callahan:
  Fix Issue 22998 - Update to zlib 1.2.12
  Update zlib to the 1.2.12 release
  Version 1.2.12 has these key improvements over 1.2.11:
  * Fix a deflate bug when using the Z_FIXED strategy that can result in out-of-bound accesses.
  * Fix a deflate bug when the window is full in deflate_stored().
  * Speed up CRC-32 computations by a factor of 1.5 to 3.
  * Use the hardware CRC-32 instruction on ARMv8 processors.
  * Speed up crc32_combine() with powers of x tables.
  * Add crc32_combine_gen() and crc32_combine_op() for fast combines.
  Due to the bug fixes, any installations of 1.2.11 should be replaced with 1.2.12.

https://github.com/dlang/phobos/pull/8428