Issue 24546 - importC musl setjmp.h failure
Summary: importC musl setjmp.h failure
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: druntime (show other issues)
Version: D2
Hardware: All Linux
: P1 major
Assignee: No Owner
URL:
Keywords: ImportC, industry, pull
Depends on:
Blocks:
 
Reported: 2024-05-08 18:41 UTC by johanengelen
Modified: 2024-05-27 12:02 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description johanengelen 2024-05-08 18:41:41 UTC
importC fails on musl libc setjmp.h, this line:
https://github.com/cloudius-systems/musl/blob/00733dd1cf791d13ff6155509cf139a5f7b2eecb/include/setjmp.h#L15

It uses identifier `__ss` which is #defined by D's importc.h:
https://github.com/dlang/dmd/blame/046679129774bf886e0650fa593c24fb2c7de499/druntime/src/importc.h#L73

Is it really needed to define `__ss` ?
Comment 2 kinke 2024-05-09 12:09:10 UTC
I hardly find anything wrt. `__ss` via Google. MSVC doesn't seem to treat it in a special way, it's a valid identifier. Could this be a DMC specificum? https://digitalmars.com/ctg/pointers16.html
Comment 3 Dlang Bot 2024-05-17 13:44:18 UTC
@JohanEngelen updated dlang/dmd pull request #16507 "Fix https://issues.dlang.org/show_bug.cgi?id=24546 for musl libc" fixing this issue:

- Fix bugzilla 24546 for musl libc

https://github.com/dlang/dmd/pull/16507
Comment 4 Dlang Bot 2024-05-19 10:09:15 UTC
dlang/dmd pull request #16507 "Fix https://issues.dlang.org/show_bug.cgi?id=24546 for musl libc" was merged into stable:

- af9f2e3234dc29f91f4029517260005a1cd87bb3 by Johan Engelen:
  Fix bugzilla 24546 for musl libc

https://github.com/dlang/dmd/pull/16507
Comment 5 Dlang Bot 2024-05-27 12:02:10 UTC
dlang/dmd pull request #16534 "merge stable" was merged into master:

- cc66e60109fb99b0983b908ebd70f1a7f9499d76 by Johan Engelen:
  Fix bugzilla 24546 for musl libc (#16507)

https://github.com/dlang/dmd/pull/16534