Issue 24812 - [REG 2.106] Incorrect highlighting when diagnosing an empty enum declaration since #15664
Summary: [REG 2.106] Incorrect highlighting when diagnosing an empty enum declaration ...
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: dmd (show other issues)
Version: D2
Hardware: All All
: P1 regression
Assignee: No Owner
URL:
Keywords: pull
Depends on:
Blocks:
 
Reported: 2024-10-14 07:16 UTC by Iain Buclaw
Modified: 2024-11-16 23:27 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Iain Buclaw 2024-10-14 07:16:55 UTC 
Test case:
```
module object;
enum Foo {}
```

Before:
```
Error: enum `object.Foo` enum `Foo` must have at least one member
```

After:
```
Error: enum `pr117115.Foo enum `Foo` must have at least one member
```

Introduced by: https://github.com/dlang/dmd/pull/15664
Comment 1 Iain Buclaw 2024-10-14 07:18:01 UTC 
(In reply to Iain Buclaw from comment #0)
> After:
> ```
> Error: enum `pr117115.Foo enum `Foo` must have at least one member
> ```
Oops, copy-paste mistake in the module name, but the odd number of backticks remains the same.
Comment 2 Dlang Bot 2024-10-14 07:57:40 UTC 
@thewilsonator created dlang/dmd pull request #17004 "Fix bugzilla issue 24812 - Incorrect highlighting when diagnosing an …" fixing this issue:

- Fix bugzilla issue 24812 - Incorrect highlighting when diagnosing an empty enum declaration

https://github.com/dlang/dmd/pull/17004
Comment 3 Dlang Bot 2024-10-14 11:03:23 UTC 
dlang/dmd pull request #17004 "Fix bugzilla issue 24812 - Incorrect highlighting when diagnosing an …" was merged into stable:

- f4ee72f350bbb4bddf276edf8d0bebbf481a9f2f by Nicholas Wilson:
  Fix bugzilla issue 24812 - Incorrect highlighting when diagnosing an empty enum declaration

https://github.com/dlang/dmd/pull/17004
Comment 4 Dlang Bot 2024-11-16 23:27:15 UTC 
dlang/dmd pull request #17069 "Merge stable" was merged into master:

- b97828fef45b55541eaefe098e5508f45c27f837 by Nicholas Wilson:
  Fix bugzilla issue 24812 - Incorrect highlighting when diagnosing an empty enum declaration (#17004)

https://github.com/dlang/dmd/pull/17069