Issue 24861 - Vestige of 16 bit code being accidentally generated
Summary: Vestige of 16 bit code being accidentally generated
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: dmd (show other issues)
Version: D2
Hardware: x86 All
: P1 minor
Assignee: No Owner
URL:
Keywords: backend, pull
Depends on:
Blocks:
 
Reported: 2024-11-15 00:10 UTC by Walter Bright
Modified: 2024-11-15 02:13 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Walter Bright 2024-11-15 00:10:38 UTC 
Line 4667 of cod2.d is:

 if (pretregs & (mES | mCX) || e.Ety & mTYfar)

but that branch should only be taken for 16 bit code. The code generated is benign, but it shouldn't be generated. The fix is:

 if (I16 && pretregs & (mES | mCX) || e.Ety & mTYfar)
Comment 1 Dlang Bot 2024-11-15 00:13:05 UTC 
@WalterBright created dlang/dmd pull request #17065 "fix bugzilla Issue 24861 - Vestige of 16 bit code being accidentally …" fixing this issue:

- fix bugzilla Issue 24861 - Vestige of 16 bit code being accidentally generated

https://github.com/dlang/dmd/pull/17065
Comment 2 Dlang Bot 2024-11-15 02:13:25 UTC 
dlang/dmd pull request #17065 "fix bugzilla Issue 24861 - Vestige of 16 bit code being accidentally …" was merged into master:

- d8d94b1b04ee68823d03663e6f21e5c8a77553e5 by Walter Bright:
  fix bugzilla Issue 24861 - Vestige of 16 bit code being accidentally generated

https://github.com/dlang/dmd/pull/17065