D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 3443 - Thread.thread_needLock() should be nothrow
Summary: Thread.thread_needLock() should be nothrow
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: druntime (show other issues)
Version: D2
Hardware: Other Windows
: P2 normal
Assignee: Sean Kelly
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-26 06:21 UTC by David Simcha
Modified: 2015-06-09 01:26 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description David Simcha 2009-10-26 06:21:38 UTC 
All it does is return a boolean member variable, so it clearly is really const pure nothrow.  Fixing this would allow me to remove a serious kludge from some of my code.
Comment 1 Sean Kelly 2009-10-30 21:53:04 UTC 
This isn't even a member of Thread, it's a global extern (C) routine.  I can mark it nothrow, but const doesn't make sense and pure doesn't apply, since its result depends on the value of a global.
Comment 2 David Simcha 2009-10-31 13:31:10 UTC 
Good enough.
Comment 3 Sean Kelly 2009-12-04 06:58:14 UTC 
Added nothrow in r209.
Comment 4 Brad Roberts 2009-12-05 22:18:44 UTC 
food for thought: the change doesn't match the bug description, and neither does the change log entry.  I'd suggest changing both to better reflect what was done.
Comment 5 David Simcha 2009-12-09 20:37:56 UTC 
Fixed.
Comment 6 Walter Bright 2009-12-31 11:19:20 UTC 
Fixed dmd 2.038