D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 3861 - std.array.put doesn't put--it takes.
Summary: std.array.put doesn't put--it takes.
Status: RESOLVED INVALID
Alias: None
Product: D
Classification: Unclassified
Component: phobos (show other issues)
Version: D2
Hardware: x86 Windows
: P2 major
Assignee: No Owner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-27 16:52 UTC by Paul D. Anderson
Modified: 2015-06-09 01:27 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Paul D. Anderson 2010-02-27 16:52:12 UTC
From the description of the put primitive in std.range:

"r.put(e) puts e in the range (in a range-dependent manner) and advances to the popFront position in the range. Successive calls to r.put add elements to the range. put may throw to signal failure."

From the example of std.array for the put function:

void main()
{
    int[] a = [ 1, 2, 3 ];
    int[] b = a;
    a.put(5);
    assert(a == [ 2, 3 ]);
    assert(b == [ 5, 2, 3 ]);
}

So, "putting" 5 into the array a removes the first element in a, and changes the value of the first element of b. I would expect the first assert in the code above to read:

    assert(a == [ 5, 1, 2, 3 ]);

The implementation of std.array.put doesn't make sense: 

void put(T, E)(ref T[] a, E e) { assert(a.length); a[0] = e; a = a[1 .. $]; }

It modifies a[0] and then replaces the array with the tail of the array, omitting the first element.

It's possible there is some arcane meaning to the word "put" that I'm not aware of, but if it means "insert an element at the front of the range" then std.array.put is wrongly implemented.

Paul
Comment 1 Paul D. Anderson 2010-03-02 17:23:21 UTC
It has been brought to my attention that the indicated behavior is correct. It was an arcane meaning of the word "put". That's what I get for thinking in English and not D.