D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 5183 - WinSock error occurs when socket is created in thread other than main
Summary: WinSock error occurs when socket is created in thread other than main
Status: RESOLVED DUPLICATE of issue 4344
Alias: None
Product: D
Classification: Unclassified
Component: phobos (show other issues)
Version: D2
Hardware: x86_64 Windows
: P2 major
Assignee: No Owner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-06 18:29 UTC by Andrew Wiley
Modified: 2010-11-08 05:18 UTC (History)
2 users (show)

See Also:

Attachments
Patch to correct the issue (214 bytes, patch)
2010-11-06 18:38 UTC, Andrew Wiley 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Andrew Wiley 2010-11-06 18:29:48 UTC 
I'm still investigating exactly what causes this, but here's a simple test case to show what I'm talking about:
import std.stdio;
import std.socket;
import core.thread;

void main() {
	testSocket();
	auto t = new Thread(&testSocket);
	t.start();
}
shared ushort port = 5000;
public void testSocket() {
	try {
		auto socket = new TcpSocket();
		socket.bind(new InternetAddress("0.0.0.0", port++));
		
	}
	catch(SocketException e) {
		writefln("Error: %d", e.errorCode);
		return;
	}
	writefln("success!");
}


The output:
success!
Error: 10093

According to http://msdn.microsoft.com/en-us/library/ms740668(VS.85).aspx the 10093 code is WSANOTINITIALISED, which means the following:
Either the application has not called WSAStartup or WSAStartup failed. The application may be accessing a socket that the current active task does not own (that is, trying to share a socket between tasks), or WSACleanup has been called too many times.

WSAStartup was definitely called because the first socket was created successfully. I'm still figuring out how the second one fails.
Comment 1 Andrew Wiley 2010-11-06 18:35:01 UTC 
Okay, after adding some debugging writeflns to std.socket, the output is now this:
initializing WSA
Initializing socket
success!
cleaning up WSA
Initializing socket
Error: 10093
cleaning up WSA

So the problem is that the module destructor for std.socket is called when the first thread terminates, even though the second thread still needs it.

This is because the module constructor for std.socket is "shared static this()" while the destructor is "static this()". Adding "shared" causes the code to run successfully.
Comment 2 Andrew Wiley 2010-11-06 18:38:34 UTC 
Created attachment 804 [details]
Patch to correct the issue
Comment 3 Stephan Dilly 2010-11-06 18:51:56 UTC 
this was already fixed in the latest release of dmd2.050
Comment 4 Andrew Wiley 2010-11-06 18:54:09 UTC 
(In reply to comment #3)
> this was already fixed in the latest release of dmd2.050

Well, this is from an install of dmd2.050 on Windows, so something didn't get updated properly.
Comment 5 Andrew Wiley 2010-11-06 18:57:27 UTC 
(In reply to comment #4)
> (In reply to comment #3)
> > this was already fixed in the latest release of dmd2.050
> 
> Well, this is from an install of dmd2.050 on Windows, so something didn't get
> updated properly.

My apologies, I seem to have 2.049. Guess I installed the new version on the other machine I develop on.
Comment 6 Steven Schveighoffer 2010-11-08 05:18:37 UTC 
Properly marking this.  Bugs that are valid on some version of D that is not the latest version are not invalid, they can be duplicates or resolved (could have been a bug that was resolved but had no matching bug in bugzilla).

Thanks

*** This issue has been marked as a duplicate of issue 4344 ***