D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 6496 - Fix std.process.browse per comments in pull request #154
Summary: Fix std.process.browse per comments in pull request #154
Status: RESOLVED FIXED
Alias: None
Product: D
Classification: Unclassified
Component: phobos (show other issues)
Version: D2
Hardware: All All
: P2 normal
Assignee: No Owner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-14 12:34 UTC by Jonathan M Davis
Modified: 2024-10-22 02:31 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Jonathan M Davis 2011-08-14 12:34:13 UTC
Due to the fact that Walter made the changes but I made the pull request, it ended up getting pulled in without adjustments to it being made as should probably have occurred. The feedback in the pull requests still needs to be applied to the code. I'm creating this issue so that it doesn't get forgotten.

https://github.com/D-Programming-Language/phobos/pull/154
Comment 1 Infiltrator 2014-03-19 19:22:17 UTC
Jonathan, did you end up forgetting about this?  :P
Comment 2 Jonathan M Davis 2014-03-19 21:45:33 UTC
> Jonathan, did you end up forgetting about this?  :P

Yes, though the bug was created so that we as a community would have a note to take care of this and thus remember to. Anyone is free to do this. I just happen to be the one who took the initiative to open the bug report. It's a weird situation, because I ended up creating a pull request for Walter's code. But clearly this bug report served its purpose, because you found it and brought thus brought it up again. It would have been completely forgotten otherwise.

I still probably should have remembered this and taken care of it by now, but anyone is free to do so.
Comment 3 Infiltrator 2014-03-19 21:51:43 UTC
Good point about this bug report.

Since you know the situation better than I, could you please list here which changes actually need to be made?
Comment 4 basile-z 2017-12-20 21:45:29 UTC
Current version of browse shows that comments have been addressed
- windows version use the ShellExecuteW() and not the A anymore
- OSX use open() if the code using $BROWSER didn't work