D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 7968 - Failing implicit cast, new in 2.059
Summary: Failing implicit cast, new in 2.059
Status: RESOLVED INVALID
Alias: None
Product: D
Classification: Unclassified
Component: dmd (show other issues)
Version: D2
Hardware: All All
: P2 normal
Assignee: No Owner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-22 11:24 UTC by Manu
Modified: 2012-04-23 10:57 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Manu 2012-04-22 11:24:21 UTC
This just appeared in 2.059:

void failCast(const(char)*[] arg)
{
}

void test(char** ppStr, uint numStrings)
{
	failCast(ppStr[0..numStrings]);
}


SQLiteDB.d(21): Error: function demu.tools.sqlitedb.failCall (const(char)*[] arg) is not callable using argument types (char*[])
SQLiteDB.d(21): Error: cannot implicitly convert expression (ppStr[0u..numStrings]) of type char*[] to const(char)*[]

The chaps on IRC seemed to think this was a bug and I should report it.
Comment 1 timon.gehr 2012-04-22 11:51:45 UTC
(In reply to comment #0)
> The chaps on IRC seemed to think this was a bug and I should report it.

They were wrong.

void failCast(const(char)*[] arg) {
    arg[0] = "123".ptr;
}

void main() {
    char*[] x = ["234".dup.ptr];
    failCast(x); // if this passes then x[0] has type char*
    assert(x[0][0..3] == "123");  //  and points into the immutable data segment
}

Change the signature of failCast to

void failCast(inout(char)*[] arg)

to get the desired semantics.
Comment 2 Manu 2012-04-22 17:02:14 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > The chaps on IRC seemed to think this was a bug and I should report it.
> 
> They were wrong.
> 
> void failCast(const(char)*[] arg) {
>     arg[0] = "123".ptr;
> }
> 
> void main() {
>     char*[] x = ["234".dup.ptr];
>     failCast(x); // if this passes then x[0] has type char*
>     assert(x[0][0..3] == "123");  //  and points into the immutable data
> segment
> }
> 
> Change the signature of failCast to
> 
> void failCast(inout(char)*[] arg)
> 
> to get the desired semantics.

I have already changed it so that it works similarly to how you describe, but I still don't follow why the cast isn't valid?
How does the cast I attempted break the const model?
Comment 3 timon.gehr 2012-04-23 10:57:19 UTC
(In reply to comment #2)
> How does the cast I attempted break the const model?

Having it be valid code allows to get a mutable reference to immutable data. This reference can then be used to (attempt to) modify the immutable data. You can refer to my first post for the counter-example.

It is an instance of the more general rule that mutable field arrays cannot be covariant and type safe without runtime checks on every store to (or load from) one of their array fields.