D issues are now tracked on GitHub. This Bugzilla instance remains as a read-only archive.
Issue 9769 - Remove opEquals from Object
Summary: Remove opEquals from Object
Status: NEW
Alias: None
Product: D
Classification: Unclassified
Component: druntime (show other issues)
Version: D2
Hardware: All All
: P4 enhancement
Assignee: No Owner
URL:
Keywords:
Depends on: 12537
Blocks: 1824
  Show dependency treegraph
 
Reported: 2013-03-21 00:02 UTC by Jonathan M Davis
Modified: 2024-12-07 13:32 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Jonathan M Davis 2013-03-21 00:02:44 UTC
Per this thread http://forum.dlang.org/post/jtlj1k$1fdj$1@digitalmars.com , it was decided to try and go the path of removing opEquals, opCmp, toHash, and toString from Object, as they don't need to be there, and the fact that they're there is causing issues with attributes such as const ( issue# 1824 ).

This issue is specifically for opEquals so that any work towards making it unnecessary and removing it can be referenced here, whereas the other 3 have separate bugzilla entries, as the work for them isn't necessarily related to each other. opEquals, opCmp, and toHash in particular may require substantial work to be done on the built-in AAs before they can actually be removed from Object, as the AA implementation is not currently templated like it should be.
Comment 1 Jonathan M Davis 2013-03-21 00:05:46 UTC
Related:

opCmp: issue# 9770
toHash: issue# 9771
toString: issue# 9772
Comment 2 Jacob Carlborg 2013-03-21 00:25:12 UTC
Was there a conclusion on how this will affect backwards compatible?
Comment 4 Jonathan M Davis 2013-03-21 00:45:19 UTC
> Was there a conclusion on how this will affect backwards compatible?

No, other than the fact that we'd probably have to keep the functions on opEquals for a while as part of the transition. I expect that the steps will be something like

1. Convert everything over in druntime so that those functions don't have to be on Object.

2. Deprecate the functions on Object.

3. Remove the functions from Object.

I expect that it'll take quite a while to go through those stages though, and it may be the case that we'll be forced to remove them from Object faster than we'd like due to some implementation issue that makes it so that keeping it around is a problem; I don't know. Regardless, the first step is making those functions on Object unnecessary, and that's going to take a while (primarily due to AAs).
Comment 5 Jonathan M Davis 2013-10-13 16:17:16 UTC
Relevant discussion on how to transition away from having these functions on Object (the thread got broken up a bit - probably by the mailman bug):

http://forum.dlang.org/post/mailman.214.1369617617.13711.digitalmars-d@puremagic.com
http://forum.dlang.org/post/mailman.280.1369712394.13711.digitalmars-d@puremagic.com

The key suggestion is to change the compiler so that those 4 functions can be free functions in object_.d, similar to how the compiler already does special stuff for == rather than simply calling Object's opEquals.
Comment 6 Jonathan M Davis 2016-04-15 09:47:53 UTC
Latest attempt to templatize the free function opEquals (which is not a full fix for this but is the first step in the process):

https://github.com/D-Programming-Language/druntime/pull/1439
Comment 7 dlangBugzillaToGithub 2024-12-07 13:32:25 UTC
THIS ISSUE HAS BEEN MOVED TO GITHUB

https://github.com/dlang/dmd/issues/17251

DO NOT COMMENT HERE ANYMORE, NOBODY WILL SEE IT, THIS ISSUE HAS BEEN MOVED TO GITHUB